Skip to content

Commit

Permalink
[Infra] Exclude pods that aren't releasing in GHAMatrixSpecCollector
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewheard committed Nov 14, 2024
1 parent 33f8419 commit 5c70711
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,10 @@ struct SDKPodspec: Codable {
struct GHAMatrixSpecCollector {
var SDKRepoURL: URL
var outputSpecFileURL: URL
var excludedSDKs: [String] = []

func getPodsInManifest(_ manifest: Manifest) -> [String: SDKPodspec] {
var podsMap: [String: SDKPodspec] = [:]
for pod in manifest.pods {
for pod in manifest.pods.filter({ $0.releasing }) {
podsMap[pod.name] = SDKPodspec(podspec: pod.name, allowWarnings: pod.allowWarnings)
}
return podsMap
Expand Down
4 changes: 1 addition & 3 deletions ReleaseTooling/Sources/ManifestParser/main.swift
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,7 @@ struct ManifestParser: ParsableCommand {
try parsePodNames(FirebaseManifest.shared)
case .forGHAMatrixGeneration:
guard let sdkRepoURL = SDKRepoURL else {
throw fatalError(
"--sdk-repo-url should be specified when --for-gha-matrix-generation is on."
)
fatalError("--sdk-repo-url should be specified when --for-gha-matrix-generation is on.")
}
let specCollector = GHAMatrixSpecCollector(
SDKRepoURL: sdkRepoURL,
Expand Down

0 comments on commit 5c70711

Please sign in to comment.