Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firebase_ui_auth): wrap email_link_sign_in_screen.dart with FirebaseUIActions #371

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ospar0829
Copy link

Solution for bug #31

Description

This PR addresses a bug in the EmailLinkSignInScreen by wrapping the UniversalScaffold widget with the FirebaseUIActions widget. The modification ensures that FirebaseUI actions are executed. Previously, the UniversalScaffold did not include Firebase UI actions, which led to actions not be executed

Related Issues

Bugfix for issue #31. This PR resolves the issue by ensuring that FirebaseUIActions are integrated, thus enabling proper handling of Firebase-related actions within the EmailLinkSignInScreen.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • All unit tests pass (melos run test:unit:all doesn't fail).
  • I read and followed the [Flutter Style Guide].
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Solution for bug firebase#31

Co-Authored-By: david150706 <[email protected]>
Copy link

google-cla bot commented Jul 7, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ospar0829 ospar0829 changed the title Update email_link_sign_in_screen.dart fix(firebase_ui_auth) email_link_sign_in_screen.dart Jul 7, 2024
@ospar0829 ospar0829 changed the title fix(firebase_ui_auth) email_link_sign_in_screen.dart [firebase_ui_auth] fix: email_link_sign_in_screen.dart Jul 7, 2024
@ospar0829 ospar0829 changed the title [firebase_ui_auth] fix: email_link_sign_in_screen.dart [firebase_ui_auth] fix(email_link_sign_in_screen): Fix email link sign in screen actions Jul 7, 2024
@ospar0829 ospar0829 changed the title [firebase_ui_auth] fix(email_link_sign_in_screen): Fix email link sign in screen actions fix(firebase_ui_auth): wrap email_link_sign_in_screen.dart with FirebaseUIActions Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant