Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firebase_ui_auth): actionsBeforeDelete callback #279

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

khanliKU
Copy link
Contributor

@khanliKU khanliKU commented Feb 5, 2024

Description

Add actionsBeforeDelete callback to ProfileScreen and DeleteAccountButton

Related Issues

N/A

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • All unit tests pass (melos run test:unit:all doesn't fail).
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@khanliKU
Copy link
Contributor Author

khanliKU commented Feb 8, 2024

I wanted to provide some additional context:
In my application, I needed to perform some cleanup work after the user accepted the "delete user" dialog. I wanted to ensure that all user records were cleared in the Firestore database, so I added an actionBeforeDelete callback. I wanted to share it with the community.

@khanliKU
Copy link
Contributor Author

I am waiting for this to be merged.

Copy link

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions bot added the Stale Issue with no recent activity label Nov 12, 2024
@russellwheatley russellwheatley added auth Keep Open Keep PR or issue open and removed Stale Issue with no recent activity labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth Keep Open Keep PR or issue open
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants