Issue 40 large dataset #1152
Merged
Issue 40 large dataset #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for papaya-valkyrie-395400 canceled.
|
heswell
force-pushed
the
issue_40_large_dataset
branch
3 times, most recently
from
905bfd0 to
a9bcbe5
Compare
heswell
force-pushed
the
issue_40_large_dataset
branch
2 times, most recently
from
16ee53c to
5f8eb2c
Compare
junaidzm13
approved these changes
Jan 25, 2024
Comment on lines
+84
to
+86
| keySet.reset({ from: 0, to: 35 }); | ||
| console.log(keySet.toDebugString()); | ||
| console.log(` nextKeyValue ${keySet["nextKeyValue"]}`); |
There was a problem hiding this comment.
Should we remove the logs now that this is resolved?
| firstRowRef.current = firstRow; | ||
| setRange({ | ||
| from: firstRow, | ||
| to: firstRow + viewportRowCount + 1, |
There was a problem hiding this comment.
In other places, we're not adjusting index by + 1 for to: when setting range. Is this intentional here?
There was a problem hiding this comment.
Good spot, this used to be the norm, but I realised when writing tests that the +1 was not correct. Leaving this one is an oversight. fixed.
heswell
force-pushed
the
issue_40_large_dataset
branch
from
5f8eb2c to
8a130c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI Table support for large datasets (> 1 million rows)
supports scrolling through full dataset with