Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add test structure for testing the hooks #65

Closed
wants to merge 12 commits into from
Closed

Conversation

ms14981
Copy link
Contributor

@ms14981 ms14981 commented Mar 17, 2020

What:

  • Uses react-scripts to run Typescript tests.
  • Add tests for useDocked as an example.
  • Tests now run on Circle CI check.
  • Tests are excluded from compile and linting checks.

Notes:

  • React changed from a peer dependency to a dependency. I'm not sure whether we want to try to keep it as a peer if possible?
  • As react-scripts is now being used in the base and demo packages, with the demo package requiring the base package as a complication, the react-scripts package is set to 3.3.0 in both to prevent conflicts.

… Typescript tests. Add tests for useDocked as an example. As react-scripts is now being used in the base and demo packages, with the demo package requiring the base package as a complication, the react-scripts package is set to 3.3.0 in both to prevent conflicts
@ms14981 ms14981 requested a review from oriondean March 17, 2020 12:30
This was referenced Mar 17, 2020
ms14981 and others added 11 commits March 17, 2020 18:09
…ot. This means that they are picked up by 'react-scripts test' where they were only being picked up by running 'jest' before
…find module 'react' from 'pure.js' However, Jest was able to find: './pure.js'` error message
…to prevent compile errors when the Typescript config option 'isolatedModules' is set to true
…ally by running 'npm test'"

This reverts commit db1f77a.
@ms14981
Copy link
Contributor Author

ms14981 commented Mar 25, 2020

Superseded by #72

@ms14981 ms14981 closed this Mar 25, 2020
@ms14981 ms14981 deleted the initial-test-setup-3 branch March 25, 2020 11:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants