Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle type args fixes #3705

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

MauricioUyaguari
Copy link
Member

@MauricioUyaguari MauricioUyaguari commented Dec 3, 2024

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

Copy link

changeset-bot bot commented Dec 3, 2024

🦋 Changeset detected

Latest commit: 51f801f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@finos/legend-extension-dsl-persistence Patch
@finos/legend-graph Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-query Patch
@finos/legend-application-repl Patch
@finos/legend-application-studio Patch
@finos/legend-code-editor Patch
@finos/legend-data-cube Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-lego Patch
@finos/legend-query-builder Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MauricioUyaguari MauricioUyaguari force-pushed the moreFixes branch 2 times, most recently from 3aa5cb4 to c0bba41 Compare December 3, 2024 14:18
@MauricioUyaguari MauricioUyaguari changed the title More fixes handle type args fixes Dec 3, 2024
@MauricioUyaguari MauricioUyaguari marked this pull request as ready for review December 3, 2024 14:18
@MauricioUyaguari MauricioUyaguari requested a review from a team as a code owner December 3, 2024 14:18
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 329 lines in your changes missing coverage. Please review.

Project coverage is 0.36%. Comparing base (1e2a720) to head (51f801f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...rializationHelpers/V1_DomainSerializationHelper.ts 0.00% 60 Missing ⚠️
...ializationHelpers/V1_MappingSerializationHelper.ts 0.00% 42 Missing ⚠️
.../pureProtocol/V1_DSL_Persistence_ProtocolHelper.ts 0.00% 35 Missing ⚠️
...sformation/pureGraph/from/V1_MappingTransformer.ts 0.00% 21 Missing ⚠️
...alizationHelpers/V1_DatabaseSerializationHelper.ts 0.00% 20 Missing ⚠️
...Graph/from/V1_DSL_Persistence_TransformerHelper.ts 0.00% 19 Missing ⚠️
.../v1/model/packageableElements/domain/V1_Profile.ts 0.00% 19 Missing ⚠️
...ers/V1_RawValueSpecificationSerializationHelper.ts 0.00% 17 Missing ⚠️
...nsformation/pureGraph/from/V1_DomainTransformer.ts 0.00% 15 Missing ⚠️
...serializationHelpers/V1_CoreSerializationHelper.ts 0.00% 14 Missing ⚠️
... and 18 more

❗ There is a different number of reports uploaded between BASE (1e2a720) and HEAD (51f801f). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (1e2a720) HEAD (51f801f)
4 2
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3705       +/-   ##
===========================================
- Coverage   45.23%    0.36%   -44.88%     
===========================================
  Files        2192     2190        -2     
  Lines      381684   381886      +202     
  Branches    11008     2278     -8730     
===========================================
- Hits       172672     1384   -171288     
- Misses     208310   378319   +170009     
- Partials      702     2183     +1481     
Files with missing lines Coverage Δ
...geableElements/store/flatData/model/V1_FlatData.ts 0.00% <0.00%> (-100.00%) ⬇️
...ableElements/store/relational/model/V1_Database.ts 0.00% <0.00%> (-100.00%) ⬇️
...rmation/pureGraph/to/V1_ElementThirdPassBuilder.ts 0.00% <0.00%> (-76.09%) ⬇️
...ents/persistence/V1_DSL_Persistence_Persistence.ts 0.00% <0.00%> (-100.00%) ⬇️
...persistence/V1_DSL_Persistence_PersistentTarget.ts 0.00% <0.00%> (-100.00%) ⬇️
...re/v1/model/packageableElements/domain/V1_Class.ts 0.00% <0.00%> (-100.00%) ⬇️
...ckageableElements/mapping/V1_AssociationMapping.ts 0.00% <0.00%> (-100.00%) ⬇️
...ckageableElements/mapping/V1_EnumerationMapping.ts 0.00% <0.00%> (-100.00%) ⬇️
...ageableElements/mapping/V1_MappingStoreTestData.ts 0.00% <0.00%> (-65.63%) ⬇️
...ureGraph/to/helpers/V1_AssociationMappingHelper.ts 0.00% <0.00%> (-97.15%) ⬇️
... and 18 more

... and 1455 files with indirect coverage changes

@MauricioUyaguari MauricioUyaguari merged commit a9b8829 into finos:master Dec 3, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants