Skip to content

Commit

Permalink
bump Node@20 and memory (#2733)
Browse files Browse the repository at this point in the history
* bump Node and memory

* bump dependencies

* adjust RAM

* remove verbose test coverage output

* use node 21
  • Loading branch information
akphi authored Oct 25, 2023
1 parent c3eba6c commit 72d1a10
Show file tree
Hide file tree
Showing 22 changed files with 184 additions and 185 deletions.
5 changes: 5 additions & 0 deletions .changeset/warm-games-divide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@finos/legend-query-builder': patch
'@finos/eslint-plugin-legend-studio': patch
'@finos/legend-art': patch
---
2 changes: 1 addition & 1 deletion .github/workflows/bot__new-issue-track.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- name: Setup Node
uses: actions/[email protected]
with:
node-version: 18
node-version: 21
- name: Install dependencies
run: yarn workspaces focus --production @finos/legend-internal-github-bot
- name: Track new milestoned issue
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/bot__onboard-new-issue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- name: Setup Node
uses: actions/[email protected]
with:
node-version: 18
node-version: 21
- name: Install dependencies
run: yarn workspaces focus --production @finos/legend-internal-github-bot
- name: Onboard new issue
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ jobs:
- name: Setup Node
uses: actions/[email protected]
with:
node-version: 18
node-version: 21
- name: Install dependencies
run: yarn
- name: Build application
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-changeset.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- name: Setup Node
uses: actions/[email protected]
with:
node-version: 18
node-version: 21
- name: Install dependencies
run: yarn
- name: Validate changesets
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/check-code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
- name: Setup Node
uses: actions/[email protected]
with:
node-version: 18
node-version: 21
- name: Install dependencies
run: yarn
# NOTE: we need this step to build the code before linting
Expand Down Expand Up @@ -70,7 +70,7 @@ jobs:
- name: Setup Node
uses: actions/[email protected]
with:
node-version: 18
node-version: 21
- name: Install dependencies
run: yarn
- name: Check package manifests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
- name: Setup Node
uses: actions/[email protected]
with:
node-version: 18
node-version: 21
- name: Install dependencies
run: yarn
- name: Build image
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-security-and-quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- name: Setup Node
uses: actions/[email protected]
with:
node-version: 18
node-version: 21
# Install step is needed for Typescript scanning to work properly since
# we refer to another packages in `tsconfig` files, which is used by Sonar
# See https://community.sonarsource.com/t/sonarts-is-not-able-to-analyse-typescript-files/21510/5
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/manual__prepare-new-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: Setup Node
uses: actions/[email protected]
with:
node-version: 18
node-version: 21
- name: Install dependencies
run: yarn
- name: Create PR for new release version bump
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/manual__publish-docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
- name: Setup Node
uses: actions/[email protected]
with:
node-version: 18
node-version: 21
- name: Install dependencies
run: yarn
- name: Check Docker image tag
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/manual__publish-npm-snapshot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: Setup Node
uses: actions/[email protected]
with:
node-version: 18
node-version: 21
# The registry URL and `NODE_AUTH_TOKEN` are needed for `npm publish` to work properly
# See https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#publish-to-npmjs-and-gpr-with-npm
registry-url: 'https://registry.npmjs.org'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-docker-snapshot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: Setup Node
uses: actions/[email protected]
with:
node-version: 18
node-version: 21
- name: Install dependencies
run: yarn
- name: Login to Docker Hub
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-website.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: Setup Node
uses: actions/[email protected]
with:
node-version: 18
node-version: 21
- name: Install dependencies
run: yarn
- name: Build website content
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- name: Setup Node
uses: actions/[email protected]
with:
node-version: 18
node-version: 21
- name: Install dependencies
run: yarn
- name: Generate new release PR title
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
- name: Setup Node
uses: actions/[email protected]
with:
node-version: 18
node-version: 21
- name: Install dependencies
run: yarn
- name: Build
Expand Down Expand Up @@ -85,7 +85,7 @@ jobs:
- name: Setup Node
uses: actions/[email protected]
with:
node-version: 18
node-version: 21
- name: Run engine server
working-directory: ./fixtures/legend-docker-setup/grammar-test-setup
run: docker compose --file=grammar-test-setup-docker-compose.yml up --detach
Expand Down
2 changes: 1 addition & 1 deletion docs/workflow/upgrade-dependencies.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ Update Node version used for pipeline workflow
- name: Setup Node
uses: actions/[email protected]
with:
node-version: 18
node-version: 21
```
### Docker
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
"@finos/eslint-plugin-legend-studio": "workspace:*",
"@finos/legend-dev-utils": "workspace:*",
"@finos/stylelint-config-legend-studio": "workspace:*",
"@types/node": "20.8.7",
"@types/node": "20.8.8",
"chalk": "5.3.0",
"cross-env": "7.0.3",
"envinfo": "7.10.0",
Expand All @@ -119,7 +119,7 @@
},
"packageManager": "[email protected]",
"engines": {
"node": ">=18.0.0",
"node": ">=21.1.0",
"yarn": ">=1.22.10"
}
}
6 changes: 3 additions & 3 deletions packages/eslint-plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@
"dependencies": {
"@babel/core": "7.23.2",
"@babel/eslint-parser": "7.22.15",
"@typescript-eslint/eslint-plugin": "6.8.0",
"@typescript-eslint/parser": "6.8.0",
"@typescript-eslint/eslint-plugin": "6.9.0",
"@typescript-eslint/parser": "6.9.0",
"eslint-config-prettier": "9.0.0",
"eslint-plugin-import": "2.28.1",
"eslint-plugin-import": "2.29.0",
"eslint-plugin-prettier": "5.0.1",
"eslint-plugin-react": "7.33.2",
"eslint-plugin-react-hooks": "4.6.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/legend-art/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"@fontsource/roboto": "5.0.8",
"@fontsource/roboto-condensed": "5.0.13",
"@fontsource/roboto-mono": "5.0.15",
"@mui/material": "5.14.14",
"@mui/material": "5.14.15",
"@types/react": "18.2.31",
"@types/react-select": "4.0.18",
"@types/react-window": "1.8.7",
Expand Down
2 changes: 1 addition & 1 deletion packages/legend-query-builder/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"react-dnd": "16.0.1",
"react-dom": "18.2.0",
"serializr": "3.0.2",
"sql-formatter": "13.0.0"
"sql-formatter": "13.0.1"
},
"devDependencies": {
"@finos/legend-dev-utils": "workspace:*",
Expand Down
1 change: 1 addition & 0 deletions scripts/test/jest.config.base.js
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ export const getBaseJestConfig = (isGlobal) => {
// See https://jestjs.io/docs/configuration#coverageprovider-string
// See https://github.com/jestjs/jest/issues/13186
coverageProvider: 'v8',
coverageReporters: ['clover', 'json', 'lcov', 'text-summary'],
coverageDirectory: '<rootDir>/build/coverage',
watchPathIgnorePatterns: [
...baseConfig.watchPathIgnorePatterns,
Expand Down
Loading

0 comments on commit 72d1a10

Please sign in to comment.