Filter reviews based on workspace source #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gayathrir11
changed the title
kevin-m-knight-gs
requested changes
Aug 29, 2023
legend-sdlc-server/src/main/java/org/finos/legend/sdlc/server/gitlab/api/GitLabReviewApi.java
Outdated
Show resolved
Hide resolved
gayathrir11
changed the title
gayathrir11
force-pushed
the
reviews
branch
2 times, most recently
from
c8c4922
to
40949cd
Compare
kevin-m-knight-gs
requested changes
Aug 29, 2023
There was a problem hiding this comment.
First, if sources is null or empty, that should mean all sources should be accepted. The logic as you have it now means that no sources will be accepted. You can fix this by only applying the filter on the MR stream if sources is non-null and non-empty.
Second, if sources is of size 1, then the target branch should be included in the MergeRequestFilter. It's best to filter things on the GitLab side when possible.
Third, if you are applying the sources filter on the MR stream, then you should use a Set rather than a List.
gayathrir11
force-pushed
the
reviews
branch
3 times, most recently
from
8931bc1
to
10732cc
Compare
kevin-m-knight-gs
requested changes
Aug 31, 2023
legend-sdlc-server/src/main/java/org/finos/legend/sdlc/server/gitlab/api/GitLabReviewApi.java
Outdated
Show resolved
Hide resolved
legend-sdlc-server/src/main/java/org/finos/legend/sdlc/server/gitlab/api/GitLabReviewApi.java
Outdated
Show resolved
Hide resolved
legend-sdlc-server/src/main/java/org/finos/legend/sdlc/server/gitlab/api/GitLabReviewApi.java
Outdated
Show resolved
Hide resolved
legend-sdlc-server/src/main/java/org/finos/legend/sdlc/server/gitlab/api/GitLabReviewApi.java
Outdated
Show resolved
Hide resolved
kevin-m-knight-gs
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.