Dataquality - Relation validation enhancements for optional from clause, query limit, unit tests #3295
Conversation
keenkeystrokes
changed the title
|
Do we need to have an explicit property for runtime? Our goal is to move towards usage of |
hi Rafael here we are ultimately using the separate property for runtime to construct the |
| functionName=from_T_m__Runtime_1__T_m_.name, | ||
| importGroup=system::imports::coreImport, | ||
| genericType=$returnType, | ||
| multiplicity=ZeroMany, |
There was a problem hiding this comment.
lets double check that ZeroMany is correct here. I would expect multiplicity to be the same as the paramValue given the function signature
| { | ||
| if (Objects.isNull(queryLimit)) | ||
| { | ||
| return core_dataquality_generation_dataquality.Root_meta_external_dataquality_generateDataQualityQuery_DataQuality_1__Integer_MANY__LambdaFunction_1_(packageableElement, Lists.immutable.empty(), pureModel.getExecutionSupport()); |
What type of PR is this?
What does this PR do / why is it needed ?
Which issue(s) this PR fixes:
Other notes for reviewers:
Does this PR introduce a user-facing change?
No