Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Compiler Warning updates #3262

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

gs-jp1
Copy link
Contributor

@gs-jp1 gs-jp1 commented Nov 20, 2024

What type of PR is this?

Improvement

What does this PR do / why is it needed ?

It removes runtime specific compiler warnings from service level compilation and instead adds checks that the runtimes and mappings associated with services are compatible.

Which issue(s) this PR fixes:

Other notes for reviewers:

Does this PR introduce a user-facing change?

@gs-jp1 gs-jp1 requested a review from a team as a code owner November 20, 2024 17:21
Copy link

Test Results

  1 015 files  +  1 015    1 015 suites  +1 015   1h 40m 28s ⏱️ + 1h 40m 28s
12 731 tests +12 731  12 606 ✔️ +12 606  125 💤 +125  0 ±0 
18 723 runs  +18 723  18 598 ✔️ +18 598  125 💤 +125  0 ±0 

Results for commit 43b68a0. ± Comparison against base commit f8f951e.

@rafaelbey rafaelbey merged commit b8d9ce6 into finos:master Nov 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants