Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow constant, inequalities and 'not' in XStore model joins #3205

Merged
merged 14 commits into from
Oct 30, 2024

Conversation

renuccif
Copy link
Contributor

Allow constant in model joins.

Allow constant in model joins
@renuccif renuccif requested a review from a team as a code owner October 24, 2024 15:23
Copy link

github-actions bot commented Oct 24, 2024

Test Results

  1 058 files  ±0    1 058 suites  ±0   1h 40m 16s ⏱️ +30s
12 827 tests +4  12 718 ✔️ +4  109 💤 ±0  0 ±0 
18 623 runs  +4  18 514 ✔️ +4  109 💤 ±0  0 ±0 

Results for commit 87ac3da. ± Comparison against base commit e107301.

♻️ This comment has been updated with latest results.

@renuccif renuccif marked this pull request as draft October 24, 2024 16:17
@renuccif renuccif marked this pull request as ready for review October 25, 2024 13:52
@renuccif renuccif changed the title Allow constant in model joins Allow constant, inequalities and 'not' in model joins Oct 25, 2024
@renuccif renuccif changed the title Allow constant, inequalities and 'not' in model joins Allow constant, inequalities and 'not' in XStore model joins Oct 25, 2024
@davidharte-gs davidharte-gs merged commit 08dd654 into finos:master Oct 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants