Persistence Component: expose input files bytes size for Snowflake BulkLoad #3201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,7 +22,9 @@ public enum StatisticName | |||
| ROWS_UPDATED("rowsUpdated"), | |||
| ROWS_DELETED("rowsDeleted"), | |||
| FILES_LOADED("filesLoaded"), | |||
| ROWS_WITH_ERRORS("rowsWithErrors"); | |||
| ROWS_WITH_ERRORS("rowsWithErrors"), | |||
|
|
|||
|
|
||
| public TabularData convertResultSetToTabularData(String sql, int rows) | ||
| { | ||
| try |
There was a problem hiding this comment.
We do not need the outside try and let it throw the exception that JDBCHelper can catch
|
|
||
| public TabularData convertResultSetToTabularData(String sql) | ||
| { | ||
| try |
There was a problem hiding this comment.
We do not need the outside try and let it throw the exception that JDBCHelper can catch
kumuwu
reviewed
Oct 24, 2024
| @@ -0,0 +1,50 @@ | |||
| // Copyright 2023 Goldman Sachs | |||
Comment on lines
+76
to
+79
| import org.finos.legend.engine.persistence.components.relational.snowflake.sql.visitor.CopyVisitor; | ||
| import org.finos.legend.engine.persistence.components.relational.snowflake.sql.visitor.DatasetAdditionalPropertiesVisitor; | ||
| import org.finos.legend.engine.persistence.components.relational.snowflake.sql.visitor.DigestUdfVisitor; | ||
| import org.finos.legend.engine.persistence.components.relational.snowflake.sql.visitor.FieldVisitor; |
There was a problem hiding this comment.
Looks redundant - should have already been imported
|
This PR is stale because it has been open for 30 days with no activity. Please remove stale label or add any comment to keep this open. Otherwise this will be closed in 5 days. |
|
This PR was closed because it has been inactive for 35 days. Please re-open if this PR is still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Improvement
What does this PR do / why is it needed ?
Added the support to return input files bytes metrics for Snowflake during bulk load in IngestorResult
Which issue(s) this PR fixes:
Other notes for reviewers:
Change proposed by @prasar-ashutosh
Does this PR introduce a user-facing change?
Only impacts users of legend-engine-xts-persistence-component