Make all identifiers for enumSourceValue in EnumMappings as single-quoted References #2736
Conversation
sprisha
changed the title
| @@ -150,7 +150,7 @@ public static String convertIdentifier(String val, boolean doubleQuotes) | |||
| } | |||
| else | |||
| { | |||
| return UNQUOTED_IDENTIFIER_PATTERN.matcher(val).matches() ? val : convertString(val, true, doubleQuotes); | |||
| return convertString(val, true, doubleQuotes); | |||
There was a problem hiding this comment.
This is not a good change, as will trigger many breaks on test cases, and will impact users that dont need quote.
I though the change is either to enhance the regex, or enhance the grammar definition so we can parse the value properly.
Test Results 70 files - 683 70 suites - 683 3m 46s ⏱️ - 1h 2m 14s For more details on these failures, see this check. Results for commit bc48593. ± Comparison against base commit ea6829a. |
|
This PR is stale because it has been open for 30 days with no activity. Please remove stale label or add any comment to keep this open. Otherwise this will be closed in 5 days. |
|
This PR was closed because it has been inactive for 35 days. Please re-open if this PR is still relevant. |
For Enum Mappings, if a user passes enum references as a source value using form Mode like this:
it converts to text mode like this:
And this fails compiling because the latter is unable to parse properly with the existing antlr rules.
So now, we will make it so we single-quote each identifier in a enum reference, like this:
This compiles properly and fixes the roundtrip issue.
What type of PR is this?
Bug fix for studioWhat does this PR do / why is it needed ?
Described above.Which issue(s) this PR fixes:
Fixes #
Other notes for reviewers:
Does this PR introduce a user-facing change?
No.