Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove overrideFlag from freemarker processing #2724

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

sprisha
Copy link
Contributor

@sprisha sprisha commented Mar 22, 2024

What type of PR is this?

What does this PR do / why is it needed ?

Earlier, we had a flag that we could set to true and rollback to old code flow if anything broke with the new flow. Now we are removing this flag and keeping 1 flow after a week in 4.40.0 release

Which issue(s) this PR fixes:

Fixes #2564

Other notes for reviewers:

Does this PR introduce a user-facing change?

No

@sprisha sprisha requested a review from a team as a code owner March 22, 2024 21:42
Copy link

github-actions bot commented Mar 22, 2024

Test Results

   202 files   -    549     202 suites   - 549   10m 46s ⏱️ - 54m 33s
4 604 tests  - 7 687  4 571 ✔️  - 7 555  32 💤  - 133  1 +1 
6 075 runs   - 9 260  6 042 ✔️  - 9 118  32 💤  - 143  1 +1 

For more details on these failures, see this check.

Results for commit 8016954. ± Comparison against base commit bcfc296.

♻️ This comment has been updated with latest results.

@sprisha
Copy link
Contributor Author

sprisha commented Mar 28, 2024

/easycla

@davidharte-gs davidharte-gs merged commit bca1939 into finos:master Apr 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants