Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Legend SQL] Add ability to externalize in arrow format #2716

Closed
wants to merge 4 commits into from

Conversation

gs-manvig
Copy link
Contributor

What type of PR is this?

Improvement

What does this PR do / why is it needed ?

Allow Alloy SQL clients to request data externalized to arrow format.

This allows users to use a memory efficient serialization format than JSON.

Other notes for reviewers:

Does this PR introduce a user-facing change?

Copy link

github-actions bot commented Mar 20, 2024

Test Results

     562 files   -    188       562 suites   - 188   28m 47s ⏱️ - 37m 5s
  8 013 tests  - 4 277    7 912 ✔️  - 4 213    99 💤  - 66  2 +2 
10 281 runs   - 5 053  10 174 ✔️  - 4 985  105 💤  - 70  2 +2 

For more details on these failures, see this check.

Results for commit 3130578. ± Comparison against base commit 6b443d5.

♻️ This comment has been updated with latest results.

<dependency>
<groupId>org.finos.legend.engine</groupId>
<artifactId>legend-engine-xt-relationalStore-executionPlan</artifactId>
</dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per my comment on the other PR, we need to avoid bringing specific stores to "core" functionality like externalize. The goal is that externalize works with "any" store, and we need to find a way to dispatch to respective store modules, if we need to.

@finos-admin
Copy link
Member

This PR is stale because it has been open for 30 days with no activity. Please remove stale label or add any comment to keep this open. Otherwise this will be closed in 5 days.

@finos-admin
Copy link
Member

This PR was closed because it has been inactive for 35 days. Please re-open if this PR is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants