Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Legend SQL] - Add metrics and tracing #2708

Merged
merged 28 commits into from
Mar 20, 2024
Merged

Conversation

shtirlets
Copy link
Contributor

@shtirlets shtirlets commented Mar 18, 2024

What type of PR is this?

Improvement

What does this PR do / why is it needed ?

Enable metrics and tracing via Open Telemetry/Zipkin

Which issue(s) this PR fixes:

Fixes #

Other notes for reviewers:

Does this PR introduce a user-facing change?

@shtirlets shtirlets requested a review from a team as a code owner March 18, 2024 19:26
Copy link

github-actions bot commented Mar 18, 2024

Test Results

     751 files  +1       751 suites  +1   1h 5m 12s ⏱️ -43s
12 290 tests +1  12 125 ✔️ +1  165 💤 ±0  0 ±0 
15 334 runs  +1  15 159 ✔️ +1  175 💤 ±0  0 ±0 

Results for commit 20dd1f4. ± Comparison against base commit 9cf6c8b.

♻️ This comment has been updated with latest results.

shtirlets and others added 17 commits March 19, 2024 09:58
…-metrics2

# Conflicts:
#	legend-engine-xts-sql/legend-engine-xt-sql-postgres-server/pom.xml
#	legend-engine-xts-sql/legend-engine-xt-sql-postgres-server/src/main/java/org/finos/legend/engine/postgres/PostgresServerLauncher.java
#	legend-engine-xts-sql/legend-engine-xt-sql-postgres-server/src/main/java/org/finos/legend/engine/postgres/PostgresWireProtocol.java
#	legend-engine-xts-sql/legend-engine-xt-sql-postgres-server/src/main/java/org/finos/legend/engine/postgres/ResultSetReceiver.java
#	legend-engine-xts-sql/legend-engine-xt-sql-postgres-server/src/main/java/org/finos/legend/engine/postgres/Session.java
#	legend-engine-xts-sql/legend-engine-xt-sql-postgres-server/src/main/java/org/finos/legend/engine/postgres/handler/legend/LegendExecutionService.java
#	legend-engine-xts-sql/legend-engine-xt-sql-postgres-server/src/main/java/org/finos/legend/engine/postgres/handler/legend/LegendHttpClient.java
@shtirlets shtirlets changed the title Add metrics and tracing [Legend SQL] - Add metrics and tracing Mar 20, 2024
@gs-manvig
Copy link
Contributor

Looks good to me.

@Yasirmod17 Yasirmod17 merged commit c69ed1e into finos:master Mar 20, 2024
4 checks passed
@shtirlets shtirlets deleted the add-metrics2 branch March 20, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants