Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the API's and logic for sink clean-up #2674

Merged
merged 12 commits into from
Mar 15, 2024

Conversation

rengam32
Copy link
Contributor

@rengam32 rengam32 commented Mar 5, 2024

What type of PR is this?

Improvement

What does this PR do / why is it needed ?

Adding API's and logic to generate and execute sink clean-up operation.

Operations performed :

Pre-actions :

  • Create audit table if not exists
  • Insert a row into audit table with status "INITIALIZED"

Drop action :

  • Drop the table

If drop goes through successfully,

  • Delete the main table entry from the metadata table
  • Insert a row into audit table with status "SUCCESS"

Else,

  • Insert a row into audit table with status "FAILED"

Which issue(s) this PR fixes:

Other notes for reviewers:

Does this PR introduce a user-facing change?

No

@rengam32 rengam32 requested a review from a team as a code owner March 5, 2024 02:32
Copy link

github-actions bot commented Mar 5, 2024

Test Results

     749 files  +1       749 suites  +1   1h 5m 23s ⏱️ +34s
12 289 tests +2  12 124 ✔️ +2  165 💤 ±0  0 ±0 
15 323 runs  +2  15 148 ✔️ +2  175 💤 ±0  0 ±0 

Results for commit 17c45e7. ± Comparison against base commit 0fecc5f.

♻️ This comment has been updated with latest results.

@epsstan epsstan merged commit 2346a00 into finos:master Mar 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants