Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null for optional field #2671

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Handle null for optional field #2671

merged 1 commit into from
Mar 1, 2024

Conversation

mateusz-klatt
Copy link
Member

What type of PR is this?

Bug Fix

What does this PR do / why is it needed ?

If change-tokens customer is still using deprecated format (with JSON serialized as string) it should provide full functionality. Fix null handling, etc.

Other notes for reviewers:

cast_generation_util_deprecated will be removed as soon as deprecated format is not needed anymore.

Does this PR introduce a user-facing change?

No

@mateusz-klatt mateusz-klatt requested a review from a team as a code owner March 1, 2024 11:55
Copy link

github-actions bot commented Mar 1, 2024

Test Results

     745 files  +3       745 suites  +3   1h 5m 29s ⏱️ + 1m 17s
12 251 tests +9  12 086 ✔️ +9  165 💤 ±0  0 ±0 
15 284 runs  +9  15 109 ✔️ +9  175 💤 ±0  0 ±0 

Results for commit ba993d4. ± Comparison against base commit 376d66b.

@kevin-m-knight-gs kevin-m-knight-gs merged commit b0d68cc into finos:master Mar 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants