Introduce a new API to update provided query fields and update query protocol to record originalVersionId #2633
Conversation
YannanGao-gs
force-pushed
the
updateQueryVersion
branch
3 times, most recently
from
e6a5fa7 to
ae6240a
Compare
YannanGao-gs
changed the title
...ion-query/src/main/java/org/finos/legend/engine/application/query/api/QueryStoreManager.java
Outdated
Show resolved
Hide resolved
...query/src/test/java/org/finos/legend/engine/application/query/api/TestQueryStoreManager.java
Outdated
Show resolved
Hide resolved
...tion-query/src/main/java/org/finos/legend/engine/application/query/api/ApplicationQuery.java
Outdated
Show resolved
Hide resolved
YannanGao-gs
force-pushed
the
updateQueryVersion
branch
from
74b60af to
3bb1e56
Compare
| { | ||
| field.setAccessible(true); | ||
| Object updatedValue = field.get(updatedQuery); | ||
| if (updatedValue != null) |
There was a problem hiding this comment.
this might require some rethinking about if we have the api take from Query updatedQuery to something ese
but one use case this current flow does not support is if we want to set a value to null if it has already been set to something.
woud using the mongo set operation help here, and update only those fields?
There was a problem hiding this comment.
If the patchQuery function still takes in a parameter of type Query that we are going to update fields upon, to generate the payload of mongo set operation, I think we'll still need to compose a document by iterating the provided parameter to get non-null fields, then call set? 😅😅
Or, could you please be more specific about what the parameter type should be? 👀😅😅
Thanks
… to record originalVersionId
YannanGao-gs
force-pushed
the
updateQueryVersion
branch
from
37d0f9c to
932e62b
Compare
What type of PR is this?
improvement
What does this PR do / why is it needed ?
Introduce a new API to update query version and update query protocol to record originalVersionId
Which issue(s) this PR fixes:
Fixes #
Other notes for reviewers:
Does this PR introduce a user-facing change?