Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection DSL does not require store #2528

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

haroonsherjan
Copy link
Contributor

What type of PR is this?

Improvement

What does this PR do / why is it needed ?

Store is not required in Relational and MongoDB DSL

@haroonsherjan haroonsherjan requested a review from a team as a code owner January 5, 2024 16:13
rafaelbey
rafaelbey previously approved these changes Jan 5, 2024
Copy link

github-actions bot commented Jan 5, 2024

Test Results

     711 files  ±0       711 suites  ±0   1h 3m 7s ⏱️ - 2m 26s
11 950 tests +2  11 777 ✔️ +2  173 💤 ±0  0 ±0 
14 959 runs  +3  14 774 ✔️ +3  185 💤 ±0  0 ±0 

Results for commit 9be121e. ± Comparison against base commit 1d09b81.

♻️ This comment has been updated with latest results.

@rafaelbey rafaelbey merged commit 625de59 into finos:master Jan 8, 2024
4 checks passed
AFine-gs pushed a commit to AFine-gs/legend-engine that referenced this pull request Jan 9, 2024
* Connection DSL does not require store

* Update Mongodb test for DSL update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants