Revert new connection APIs #2506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epsstan
requested review from
pierredebelen,
davidharte-gs,
gs-ssh16,
rafaelbey and
aormerod-gs
as code owners
Merged
epsstan
force-pushed
the
revert_authn
branch
from
433b195 to
1def3aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Improvement
What does this PR do / why is it needed ?
Reverts @akphi's PRs that introduced new connection APIs. These APIs will be replaced by new implementations from @pierredebelen.
In this PR, we first remove references to connection APIs that come from these two modules :
legend-engine-xt-connection-factory
legend-engine-xt-connection-protocol
These modules will be removed in the next PR.
Which issue(s) this PR fixes:
Fixes #
Other notes for reviewers:
Does this PR introduce a user-facing change?
No