Persistence Component: Enable Batch ID for Nontemporal Modes #2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumuwu
changed the title
kumuwu
changed the title
epsstan
approved these changes
Jan 18, 2024
AFine-gs
pushed a commit
to AFine-gs/legend-engine
that referenced
this pull request
Jan 22, 2024
) Co-authored-by: prasar-ashutosh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do / why is it needed ?
Introduced batch id field for Append Only, Nontemporal Snapshot and Nontemporal Delta.
This means these modes will now ingest a "batch_id" column which is similar to the "batch_id_in" column of temporal modes. Note that this also means that all the nontemporal modes will now also trigger an ingestion into the metadata table, for keeping track of the batches as well as other metadata.
New APIs introduced to allow users to possibly run multiple ingest in the same transaction.
Which issue(s) this PR fixes:
Fixes #
Other notes for reviewers:
Does this PR introduce a user-facing change?