Feature/bigquery jdbc wrapper #2492
Conversation
|
| @@ -0,0 +1,236 @@ | |||
| <?xml version="1.0"?> | |||
There was a problem hiding this comment.
Update copyright header to mention Google.
There was a problem hiding this comment.
Actually .. Don't think we need this checstyle.xml here. The root checkstyle.xml should suffice
| @@ -0,0 +1,99 @@ | |||
| <project xmlns="http://maven.apache.org/POM/4.0.0" | |||
There was a problem hiding this comment.
Update copyright header to include Google + Apache License.
Please make this change for all source files
| * Copyright 2020 Google LLC | ||
| */ | ||
|
|
||
| package com.deloitte.legend.engine.bigquery; |
There was a problem hiding this comment.
Should this be com.google ? Also, this class is technically not a part of the "engine".
Can we rename this to com.google.bigquery.jdbc
| @@ -0,0 +1,229 @@ | |||
| Legend SQL Compatibility Report | |||
There was a problem hiding this comment.
This test summary md file will become stale as the codebase evolves.
Please remove from the PR. Might be good to attach to the PR as a doc attachment.
There was a problem hiding this comment.
Same as the above summary md file. Please remove the junit test result xml.
There was a problem hiding this comment.
Same as the above summary md file. Please remove the junit test result xml.
| import java.util.Properties; | ||
| import java.util.logging.Logger; | ||
|
|
||
| public class BigQueryDriver implements Driver |
There was a problem hiding this comment.
Can we a simple Junit test that makes a connection and asserts that the connection is valid ?
We can provide the credentials and BigQuery endpoint coordinates to connect.
What type of PR is this?
Improvement
What does this PR do / why is it needed ?
This PR introduces a new JDBC wrapper for BigQuery, aimed at replacing the existing Simba driver. The key motivation for this enhancement is to provide a more efficient and reliable way of interfacing with BigQuery by utilizing the BigQuery client library.
Which issue(s) this PR fixes:
Other notes for reviewers:
Please review the implementation details, focusing on the integration of the BigQuery client library.
Any feedback on the compatibility and performance improvements compared to the Simba driver would be highly appreciated.
The changes have been thoroughly tested, but additional insights or tests from the reviewers would be valuable.
Does this PR introduce a user-facing change?
No