Improve efficiency on some elasticsearch queries grouping by computed if/else fields #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidharte-gs
approved these changes
Dec 1, 2023
AFine-gs
pushed a commit
to AFine-gs/legend-engine
that referenced
this pull request
Jan 9, 2024
… if/else fields (finos#2491) * Improve efficiency on some elasticsearch queries grouping by computed if/else fields * Handle Date type on painless script * Ensure else is handle as "other" bucket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Improvement
What does this PR do / why is it needed ?
When grouping by fields that are bucketing using if/else, is more efficient to use filters bucket aggregation rather than scripting a runtime field to group by after. This will avoid the scripting, which can be resource intensive.
Which issue(s) this PR fixes:
Fixes #
Other notes for reviewers:
Does this PR introduce a user-facing change?