Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otherwise embedded mapping graphfetch #2488

Merged

Conversation

tanujgirdhar
Copy link
Contributor

What type of PR is this?

What does this PR do / why is it needed ?

Which issue(s) this PR fixes:

Fixes #

Other notes for reviewers:

Does this PR introduce a user-facing change?

* always route to otherwiseMapping for graphFetchFlow

* fix otherwise embedded mapping for graphfetch

* behave as if embedded mapping were empty
@tanujgirdhar tanujgirdhar changed the title Review embedded mapping graphfetch otherwise embedded mapping graphfetch Nov 30, 2023
Copy link

Test Results

     708 files  ±  0       708 suites  ±0   1h 3m 28s ⏱️ + 1m 45s
11 841 tests +20  11 419 ✔️ +20  422 💤 ±0  0 ±0 
14 836 runs  +46  14 315 ✔️ +46  521 💤 ±0  0 ±0 

Results for commit d9d0ba0. ± Comparison against base commit 8e935d4.

@gs-ssh16 gs-ssh16 merged commit 7fa7306 into finos:master Nov 30, 2023
4 checks passed
AFine-gs pushed a commit to AFine-gs/legend-engine that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants