Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use parent temp table strategy in cross store node #2481

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

abhishoya-gs
Copy link
Contributor

What type of PR is this?

Bug fix

What does this PR do / why is it needed ?

Fixes NPE in cross store graph fetch

Which issue(s) this PR fixes:

Fixes #

Other notes for reviewers:

Does this PR introduce a user-facing change?

Yes, bug fix

@abhishoya-gs abhishoya-gs requested a review from a team as a code owner November 28, 2023 05:33
Copy link

Test Results

     705 files  ±0       705 suites  ±0   1h 2m 4s ⏱️ +41s
11 716 tests ±0  11 302 ✔️ ±0  414 💤 ±0  0 ±0 
14 655 runs  ±0  14 149 ✔️ ±0  506 💤 ±0  0 ±0 

Results for commit b967f33. ± Comparison against base commit 0e87369.

@gs-ssh16
Copy link
Contributor

Can you add in a unit test

@gs-ssh16 gs-ssh16 merged commit 8e935d4 into finos:master Nov 30, 2023
3 checks passed
AFine-gs pushed a commit to AFine-gs/legend-engine that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants