Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change tokens - do not mutate input map, do not cache output object type #2477

Closed
wants to merge 1 commit into from
Closed

change tokens - do not mutate input map, do not cache output object type #2477

wants to merge 1 commit into from

Conversation

mateusz-klatt
Copy link
Member

What type of PR is this?

  1. BugFix
  2. Improvement

What does this PR do / why is it needed ?

  1. Fix the issue with rename class followed by other tokens in the same version of changes
  2. Do not mutate input map - create a deep copy and apply change tokens on the fly

Other notes for reviewers:

Does this PR introduce a user-facing change?

No

@mateusz-klatt mateusz-klatt requested a review from a team as a code owner November 24, 2023 15:00
@github-actions GitHub Actions
Copy link

Test Results

     708 files  +  3       708 suites  +3   1h 1m 53s ⏱️ +30s
11 738 tests +22  11 324 ✔️ +22  414 💤 ±0  0 ❌ ±0 
14 677 runs  +22  14 171 ✔️ +22  506 💤 ±0  0 ❌ ±0 

Results for commit c61d96b. ± Comparison against base commit 0e87369.

@mateusz-klatt
Copy link
Member Author

Replaced with #2479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aziemchawdhary-gs aziemchawdhary-gs aziemchawdhary-gs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateusz-klatt @aziemchawdhary-gs