otherwise embedded mapping support #2476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* always route to otherwiseMapping for graphFetchFlow * fix otherwise embedded mapping for graphfetch * behave as if embedded mapping were empty
tanujgirdhar
requested review from
a team,
pierredebelen,
epsstan,
davidharte-gs,
gs-ssh16,
rafaelbey and
aormerod-gs
as code owners
rafaelbey
reviewed
Nov 27, 2023
| @@ -12,6 +12,7 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| import meta::relational::mapping::*; | |||
There was a problem hiding this comment.
How is this import used? Can it be removed?
Seems that this is breaking encapsulation - core libraries depending on the implementation of relational.
There was a problem hiding this comment.
yes, this can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no changes needed for relationalGraphFetch
always route to otherwiseMapping for graphFetchFlow
fix otherwise embedded mapping for graphfetch
behave as if embedded mapping were empty
What type of PR is this?
What does this PR do / why is it needed ?
Which issue(s) this PR fixes:
Fixes #
Other notes for reviewers:
Does this PR introduce a user-facing change?