Relational - sortBy accepts lambda function #2460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gs-ssh16
reviewed
Nov 15, 2023
...lStore-pure/src/main/resources/core_relational/relational/pureToSQLQuery/pureToSQLQuery.pure
Outdated
Show resolved
Hide resolved
...lStore-pure/src/main/resources/core_relational/relational/pureToSQLQuery/pureToSQLQuery.pure
Outdated
Show resolved
Hide resolved
...lStore-pure/src/main/resources/core_relational/relational/pureToSQLQuery/pureToSQLQuery.pure
Outdated
Show resolved
Hide resolved
gs-ssh16
approved these changes
Nov 30, 2023
AFine-gs
pushed a commit
to AFine-gs/legend-engine
that referenced
this pull request
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Improvement
What does this PR do / why is it needed ?
This PR adds support for lambda function inside sortBy function in a relational runtime. It's needed to support advanced use cases where path isn't useful. For example in cases where we want to pass in a variable, path fails on compilation and where we don't want to add qualified properties just for sorting by on it.
Which issue(s) this PR fixes:
Fixes #
Other notes for reviewers:
Snowflake https://docs.snowflake.com/en/sql-reference/constructs/order-by
Sybase https://infocenter.sybase.com/help/index.jsp?topic=/com.sybase.infocenter.dc36272.1570/html/commands/X14000.htm
DB2 https://www.ibm.com/docs/en/i/7.3?topic=statement-order-by-clause
H2 - tests
Does this PR introduce a user-facing change?
yes, users will be able to pass in a lambda functoin to sortBy