SybaseIQ SQL generation fixes - Handling boolean operations #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do / why is it needed ?
SybaseIQ doesn't support Boolean Literals. This pr includes two changes that are related boolean handling in sybase.
Change in dbExtension (this applies to all the dbs that don't support boolean literals) -
Scope of this change is dyna functions (that aren't boolean operations) and can take Boolean operations as parameters.
For such functions, we need to explicitly handle the return value of boolean operations. We do that by wrapping the boolean operation parameters in a case statement.
Change in sybaseIqExtension -
The having clause is always expected to return a boolean. We use wrapAsBooleanOperation() on the having string to handle the boolean operations.
Which issue(s) this PR fixes:
Fixes #
Other notes for reviewers:
Does this PR introduce a user-facing change?
No