GraphQL - Filter out fields with any type during introspection #2394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishoya-gs
requested review from
pierredebelen,
epsstan,
davidharte-gs,
gs-ssh16,
rafaelbey and
aormerod-gs
as code owners
Test Results 694 files + 694 694 suites +694 59m 18s ⏱️ + 59m 18s Results for commit 6e0d40f. ± Comparison against base commit fb7e2bb. ♻️ This comment has been updated with latest results. |
|
/easycla |
gs-ssh16
previously approved these changes
Oct 23, 2023
gs-ssh16
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do / why is it needed ?
Fixes introspection for pure models with fields on Any type.
Any type is a programming construct but can occur in models / dependency models. This doesn't carry significance in modelling. So, we can filter out fields with any type in introspection.
Which issue(s) this PR fixes:
Fixes #
Other notes for reviewers:
In tests it's a delta change in model but not in assert since code is filtering out such fields.
Does this PR introduce a user-facing change?