Mark org as Pure Reserved Keyword #2387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrudula-gs
requested review from
a team,
pierredebelen,
epsstan,
davidharte-gs,
gs-ssh16,
rafaelbey and
aormerod-gs
as code owners
Test Results 694 files + 694 694 suites +694 1h 1m 37s ⏱️ + 1h 1m 37s Results for commit f0cbc31. ± Comparison against base commit ccf31bb. ♻️ This comment has been updated with latest results. |
aziemchawdhary-gs
requested changes
Oct 19, 2023
...-engine-xt-javaGeneration-pure/src/main/resources/core_external_language_java/metamodel.pure
Outdated
Show resolved
Hide resolved
aziemchawdhary-gs
previously approved these changes
Oct 20, 2023
|
\easycla |
davidharte-gs
approved these changes
Oct 27, 2023
...-engine-protocol-generation-pure/src/main/resources/core_protocol_generation/generation.pure
Outdated
Show resolved
Hide resolved
...vaGeneration-pure/src/main/resources/core_external_language_java/generation/conventions.pure
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do / why is it needed ?
On the generated java for model to model use case, to handle Data Quality we try to resolve the java class "org.finos.legend.engine.plan.dependencies.domain.dataQuality.IDefect"
This can fail at compilation when we have any class properties with name as "org" as it will be in the same scope.
Does this PR introduce a user-facing change?
No