Mark org as a Reserved keyword #2374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrudula-gs
requested review from
a team,
pierredebelen,
epsstan,
davidharte-gs,
gs-ssh16,
rafaelbey and
aormerod-gs
as code owners
Test Results 688 files + 688 688 suites +688 1h 2m 22s ⏱️ + 1h 2m 22s Results for commit 1251b2bd. ± Comparison against base commit 1b53721. ♻️ This comment has been updated with latest results. |
mrudula-gs
force-pushed
the
reservedWord
branch
from
1251b2b to
bf16495
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do / why is it needed ?
On the generated java for model to model use case, to handle Data Quality we try to resolve the java class "org.finos.legend.engine.plan.dependencies.domain.dataQuality.IDefect"
This can fail at compilation when we have any class properties with name as "org" as it will be in the same scope.
Does this PR introduce a user-facing change?
No