Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temptable memsql fix #2362

Closed

Conversation

PrateekGarg-gs
Copy link
Contributor

What type of PR is this?

Improvement

What does this PR do / why is it needed ?

memsql temptable fixes

  • add a flag for normalizeWithTimeZone
  • fix pureDate formatting of subseconds of precision > milliseconds

Which issue(s) this PR fixes:

Fixes #

Other notes for reviewers:

Does this PR introduce a user-facing change?

@github-actions
Copy link

Test Results

     683 files  +     683       683 suites  +683   1h 0m 12s ⏱️ + 1h 0m 12s
11 291 tests +11 291  10 911 ✔️ +10 911  380 💤 +380  0 ±0 
14 082 runs  +14 082  13 618 ✔️ +13 618  464 💤 +464  0 ±0 

Results for commit 00ddedf. ± Comparison against base commit a8d72b3.

@PrateekGarg-gs
Copy link
Contributor Author

Closing in favour of https://github.com/finos/legend-engine/pull/2371/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant