Legend SQL - assortment of changes #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. allow realias of column to table column name 2. splitPart support 3. handle aggregations within case statement
gs-jp1
requested review from
a team,
pierredebelen,
epsstan,
davidharte-gs,
gs-ssh16 and
hardikmaheshwari
as code owners
Test Results 684 files + 684 684 suites +684 1h 0m 4s ⏱️ + 1h 0m 4s Results for commit 9ef877c. ± Comparison against base commit 8205951. ♻️ This comment has been updated with latest results. |
aormerod-gs
approved these changes
Oct 4, 2023
|
/easycla |
davidharte-gs
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Improvement/Bug Fix
What does this PR do / why is it needed ?
Which issue(s) this PR fixes:
Other notes for reviewers:
Does this PR introduce a user-facing change?