Update LegendTdsResultParser to handle columns without relationalType #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shtirlets
changed the title
aormerod-gs
reviewed
Oct 3, 2023
...ver/src/main/java/org/finos/legend/engine/postgres/handler/legend/LegendTdsResultParser.java
Outdated
Show resolved
Hide resolved
aormerod-gs
reviewed
Oct 3, 2023
...ver/src/main/java/org/finos/legend/engine/postgres/handler/legend/LegendTdsResultParser.java
Outdated
Show resolved
Hide resolved
aormerod-gs
reviewed
Oct 3, 2023
...ver/src/main/java/org/finos/legend/engine/postgres/handler/legend/LegendTdsResultParser.java
Outdated
Show resolved
Hide resolved
…/main/java/org/finos/legend/engine/postgres/handler/legend/LegendTdsResultParser.java
…/main/java/org/finos/legend/engine/postgres/handler/legend/LegendTdsResultParser.java
…/main/java/org/finos/legend/engine/postgres/handler/legend/LegendTdsResultParser.java
aormerod-gs
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do / why is it needed ?
Legend response does not provide "relationalType" for derived columns. Update the parser on Legend SQL Engine to handle the use case.
Which issue(s) this PR fixes:
Fixes #
Other notes for reviewers:
Does this PR introduce a user-facing change?