add mastery runtime grammar and protocol changes #2303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| if (masterRecordDefinition == null) | ||
| { | ||
| return null; |
There was a problem hiding this comment.
Shouldn't we throw an exception here (similar to line 63 below)?
| List<String> duplicateMasterRecords = ListIterate.select(masterRecordDefinitions, m -> !uniqueMasterRecordDefinitions.add(m)); | ||
| if (!duplicateMasterRecords.isEmpty()) | ||
| { | ||
| throw new EngineException(format("The following master record definitions %s appear multiple times. There cannot be duplicate masterRecordDefinitions across one or multiple mastery runtimes.", duplicateMasterRecords), EngineErrorType.PARSER); |
There was a problem hiding this comment.
Can we make the error message consistent? master record definition or masterRecordDefinition?
hausea
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add mastery runtime grammar and protocol changes