add support for pushing down sql enum transforms #2283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AFine-gs
requested review from
a team,
pierredebelen,
epsstan,
davidharte-gs,
gs-ssh16 and
hardikmaheshwari
as code owners
rafaelbey
reviewed
Sep 20, 2023
...lStore-pure/src/main/resources/core_relational/relational/pureToSQLQuery/pureToSQLQuery.pure
Show resolved
Hide resolved
AFine-gs
commented
Sep 26, 2023
| @@ -156,12 +199,13 @@ function meta::pure::executionPlan::executionPlan(clusters:ClusteredValueSpecifi | |||
|
|
|||
| function meta::pure::executionPlan::generatePlatformCode(plan:ExecutionPlan[1], platformId:String[1], config:meta::pure::executionPlan::platformBinding::PlatformBindingConfig[1], extensions:meta::pure::extension::Extension[*]):ExecutionPlan[1] | |||
| { | |||
| meta::pure::executionPlan::generatePlatformCode($plan, $platformId, $config, $extensions, if(isOptionSet('DebugPlatformCodeGen'), |debug(), |noDebug())); | |||
| meta::pure::executionPlan::generatePlatformCode($plan, $platformId, $config, $extensions, if(isOptionSet('DebugPlatformCodeGen'), |debug(), |debug())); | |||
| } | |||
There was a problem hiding this comment.
remove debug change
AFine-gs
force-pushed
the
enumpushtosql
branch
from
722a114 to
3137bf5
Compare
AFine-gs
force-pushed
the
enumpushtosql
branch
from
3137bf5 to
7b96273
Compare
davidharte-gs
previously approved these changes
Oct 6, 2023
|
This PR is stale because it has been open for 30 days with no activity. Please remove stale label or add any comment to keep this open. Otherwise this will be closed in 5 days. |
|
\easycla |
|
/easycla |
|
This PR is stale because it has been open for 30 days with no activity. Please remove stale label or add any comment to keep this open. Otherwise this will be closed in 5 days. |
|
This PR was closed because it has been inactive for 35 days. Please re-open if this PR is still relevant. |
AFine-gs
force-pushed
the
enumpushtosql
branch
from
5a729a3 to
2f58b07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do / why is it needed ?