fix build by trying to turn off sonar

finos · Oct 30, 2023 · f769e78 · f769e78
1 parent 4d620e4
commit f769e78
Showing 1 changed file with 20 additions and 15 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -71,23 +71,28 @@ jobs:
       - name: Build + Test
         if: github.ref != 'refs/heads/master'
         run: |
-          mvn -B -e -DskipTests=true install
+          mvn -B -e -DskipTests=true deploy
           mvn -B -e surefire:test -DargLine="-XX:MaxRAMPercentage=70.0" -Dsurefire.reports.directory=${GITHUB_WORKSPACE}/surefire-reports-aggregate
+      # - name: Build + Test
+      #   if: github.ref != 'refs/heads/master'
+      #   run: |
+      #     mvn -B -e -DskipTests=true deploy
+      #     mvn -B -e surefire:test -DargLine="-XX:MaxRAMPercentage=70.0" -Dsurefire.reports.directory=${GITHUB_WORKSPACE}/surefire-reports-aggregate
 
-      - name: Build + Test + Maven Deploy + Sonar + Docker Snapshot
-        if: github.ref == 'refs/heads/master'
-        env:
-          DOCKER_USERNAME: finos
-          DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
-        # NOTE: here we publish snapshot to a staging Maven registry
-        # some registry like Maven Central requires javadoc, but for now we
-        # don't need to, if we do, call javadoc:jar goal instead of javadoc:javadoc
-        # as the latter binds to generate-sources which runs before compile phase
-        # and can cause problem with some code generators
-        # See https://github.com/finos/legend-engine/pull/924
-        run: |
-          mvn -B -e -DskipTests=true deploy -P docker-snapshot,sonar
-          mvn -B -e surefire:test -DargLine="-XX:MaxRAMPercentage=70.0" -Dsurefire.reports.directory=${GITHUB_WORKSPACE}/surefire-reports-aggregate
+      # - name: Build + Test + Maven Deploy + Sonar + Docker Snapshot
+      #   if: github.ref == 'refs/heads/master'
+      #   env:
+      #     DOCKER_USERNAME: finos
+      #     DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
+      #   # NOTE: here we publish snapshot to a staging Maven registry
+      #   # some registry like Maven Central requires javadoc, but for now we
+      #   # don't need to, if we do, call javadoc:jar goal instead of javadoc:javadoc
+      #   # as the latter binds to generate-sources which runs before compile phase
+      #   # and can cause problem with some code generators
+      #   # See https://github.com/finos/legend-engine/pull/924
+      #   run: |
+      #     mvn -B -e -DskipTests=true deploy -P docker-snapshot,sonar
+      #     mvn -B -e surefire:test -DargLine="-XX:MaxRAMPercentage=70.0" -Dsurefire.reports.directory=${GITHUB_WORKSPACE}/surefire-reports-aggregate
 
       - name: Upload Test Results
         if: always()