Reject spaces in execution keys (#2802)

* Dont allow spaces in execution keys Dont allow spaces in execution keys * Update ServiceParseTreeWalker.java
finos · Apr 24, 2024 · f2c2be1 · f2c2be1
1 parent 6208120
commit f2c2be1
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/...rg/finos/legend/engine/language/pure/dsl/service/grammar/from/ServiceParseTreeWalker.java b/...rg/finos/legend/engine/language/pure/dsl/service/grammar/from/ServiceParseTreeWalker.java
@@ -575,6 +575,10 @@ private SingleExecutionParameters visitSingleExecutionParameters(ServiceParserGr
         SingleExecutionParameters singleExecParams = new SingleExecutionParameters();
         singleExecParams.sourceInformation = walkerSourceInformation.getSourceInformation(ctx);
         singleExecParams.key = PureGrammarParserUtility.fromIdentifier(ctx.identifier());
+        if (singleExecParams.key.contains(" "))
+        {
+            throw new EngineException("Execution param key cannot contain spaces. Invalid Key: " + singleExecParams.key, singleExecParams.sourceInformation, EngineErrorType.PARSER);
+        }
         ServiceParserGrammar.ServiceMappingContext mappingContext = PureGrammarParserUtility.validateAndExtractRequiredField(Collections.singletonList(ctx.serviceMapping()), "mapping", singleExecParams.sourceInformation);
         singleExecParams.mapping = PureGrammarParserUtility.fromQualifiedName(mappingContext.qualifiedName().packagePath() == null ? Collections.emptyList() : mappingContext.qualifiedName().packagePath().identifier(), mappingContext.qualifiedName().identifier());
         singleExecParams.mappingSourceInformation = walkerSourceInformation.getSourceInformation(mappingContext.qualifiedName());