update to some PR comments

finos · Oct 21, 2019 · 76265c0 · 76265c0
1 parent f1ca398
commit 76265c0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...ava/com/scottlogic/deg/generator/generation/fieldvaluesources/LinearFieldValueSource.java b/...ava/com/scottlogic/deg/generator/generation/fieldvaluesources/LinearFieldValueSource.java
@@ -58,7 +58,7 @@ public Stream<T> generateRandomValues(RandomNumberGenerator randomNumberGenerato
             .filter(this::notInBlacklist);
     }
 
-
+    // we call this instead of .contains because .contains doesn't treat 2 and 2.0 as equal
     private boolean notInBlacklist(T t) {
         return blacklist.stream().noneMatch(x->x.compareTo(t)==0);
     }

diff --git a/...ic/deg/generator/generation/fieldvaluesources/datetime/DateTimeFieldValueSourceTests.java b/...ic/deg/generator/generation/fieldvaluesources/datetime/DateTimeFieldValueSourceTests.java
@@ -43,7 +43,7 @@ public class DateTimeFieldValueSourceTests {
     private Limit<OffsetDateTime> lowerLimit = DATETIME_MIN_LIMIT;
     private Limit<OffsetDateTime> upperLimit = DATETIME_MAX_LIMIT;
     private Set<Object> blackList = new HashSet<>();
-    private LinearFieldValueSource fieldSource;
+    private LinearFieldValueSource<OffsetDateTime> fieldSource;
 
     @Test
     public void whenGeneratingUnboundSet() {