Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Slicing end default to None #151

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Change Slicing end default to None #151

merged 2 commits into from
Dec 13, 2023

Conversation

limiteinductive
Copy link
Member

Currently, you cannot express open-ended slices like x[1:] because by default, end was set to -1.

deltheil
deltheil previously approved these changes Dec 13, 2023
View reviewed changes
tests/fluxion/layers/test_basics.py Outdated Show resolved Hide resolved
@limiteinductive limiteinductive force-pushed the pr/fix-default-end-for-slicing branch from d15af2b to f8a7689 Compare December 13, 2023 15:54
@limiteinductive limiteinductive merged commit e2f2e33 into main Dec 13, 2023
1 check passed
@limiteinductive limiteinductive deleted the pr/fix-default-end-for-slicing branch December 13, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltheil deltheil deltheil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@limiteinductive @deltheil