Skip to content

Commit

Permalink
Merge pull request #606 from openfin/alpha
Browse files Browse the repository at this point in the history
v2.0.2 Master
  • Loading branch information
Dwaynekj authored Jun 4, 2017
2 parents a2784af + a7369c1 commit ccda439
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 21 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Below is an example custom application built ontop of the Hypergrid API tooling.
* [Roadmap](https://github.com/openfin/fin-hypergrid/blob/master/README.md#roadmap)
* [Contributing](https://github.com/openfin/fin-hypergrid/blob/master/README.md#contributors)

### Current Release (2.0.0 - 16 May 2017)
### Current Release (2.0.2 - 4 June 2017)

2.0 reflects a substantial simplification of the core functionality of the grid to just customized rendering. The rendering engine does allow support for showing sorting, filtering, grouping, etc. but specific logic on how a user may want to do that is not apart for this project. Demos will be made available on the [wiki](https://github.com/openfin/fin-hypergrid/wiki) for this.

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "fin-hypergrid",
"version": "2.0.1",
"version": "2.0.2",
"description": "Canvas-based high-performance spreadsheet",
"repository": {
"type": "git",
Expand Down
36 changes: 17 additions & 19 deletions src/Hypergrid.js
Original file line number Diff line number Diff line change
Expand Up @@ -286,25 +286,6 @@ var Hypergrid = Base.extend('Hypergrid', {
clearState: function() {
this._theme = Object.create(defaults);

/**
* @summary The theme layer in the properties hierarchy.
* @desc The theme layer is the second layer, above the `defaults` layer, and below the `properties` layer.
* Attempting to reset the theme throws an error (to guard against confusion with the `properties.theme` setter).
* @name theme
* @type {object}
* @summary The prototype layer where theme look and feel properties can be defined.
* @type {object}
* @memberOf Hypergrid#
*/
Object.defineProperty(this, 'theme', {
get: function() {
return this._theme;
},
set: function(theme) {
throw new this.HypergridError('Cannot reset grid.theme (properties layer). Use grid.applyTheme or the grid.properties.theme setter to apply a new theme.');
}
});

/**
* @name properties
* @type {object}
Expand Down Expand Up @@ -2229,6 +2210,23 @@ var Hypergrid = Base.extend('Hypergrid', {
: themeName in Hypergrid.themes
? themeName // registered theme name
: theme; // unregistered theme object
},

/**
* @summary The theme layer in the properties hierarchy.
* @desc The theme layer is the second layer, above the `defaults` layer, and below the `properties` layer.
* Attempting to reset the theme throws an error (to guard against confusion with the `properties.theme` setter).
* @name theme
* @type {object}
* @summary The prototype layer where theme look and feel properties can be defined.
* @type {object}
* @memberOf Hypergrid#
*/
get theme() {
return this._theme;
},
set theme(theme) {
console.warn('Attempt to reset grid.theme (properties layer). Use grid.applyTheme or the grid.properties.theme setter to apply a new theme.');
}
});

Expand Down

0 comments on commit ccda439

Please sign in to comment.