Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve introduction example. #110

Merged
merged 3 commits into from
Jul 20, 2024
Merged

Improve introduction example. #110

merged 3 commits into from
Jul 20, 2024

Conversation

malteneuss
Copy link
Contributor

@malteneuss malteneuss commented Jul 20, 2024

@fimad Thanks for this awesome library. I tried to improve the introduction section as follows:

  • Shorten example html a bit and make it complete such that it can be copy pasted to get up and running fast.
  • Include raw string scraping example as many modern pages require more involved web page fetching (so fetched by other means).
  • Highlight unique selling points of this library early.
  • Move example close to the top to give an immediate impression on how to use it.

Feel free to modify this PR, request changes or close it as you wish.

@fimad fimad merged commit 0e49259 into fimad:master Jul 20, 2024
5 checks passed
@fimad
Copy link
Owner

fimad commented Jul 20, 2024

Looks good, appreciate you taking the time to improve the documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants