Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable bucket for latency metric #69

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

Yuras
Copy link
Contributor

@Yuras Yuras commented Mar 21, 2023

See #68

This adds instrumentHandlerValueWithHistogramAndFilter which allows to use custom histogram, e.g. specify custom buckets, metric name, names for labels.

@jonathanjouty
Copy link

@fimad Thanks for the libraries 🙌🏽
Is there anything we @scrive can do to help get this change (or an alternative solution for #68) reviewed and released?

@fimad
Copy link
Owner

fimad commented Jul 7, 2024

Looks good to me, sorry this fell off my radar.

@fimad fimad merged commit 423e90d into fimad:master Jul 7, 2024
@jonathanjouty
Copy link

Thank you!

@Yuras Yuras deleted the wip/yuras/configurable_bucket branch October 8, 2024 11:00
@Yuras Yuras restored the wip/yuras/configurable_bucket branch October 8, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants