-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Quality: Migrated shared properties to props file #16557
base: main
Are you sure you want to change the base?
Changes from all commits
cc2ec70
3334e7e
76f36e0
8e27993
0a0c0be
e1452ca
1b831f3
15f9a46
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
<!-- Copyright (c) 2024 Files Community. Licensed under the MIT License. See the LICENSE. --> | ||
<Project> | ||
|
||
<PropertyGroup Condition="'$(MSBuildProjectExtension)' == '.csproj'"> | ||
<Configurations>Debug;Release;Stable;Preview;Store</Configurations> | ||
<Platforms>x86;x64;arm64</Platforms> | ||
<RuntimeIdentifiers>win-x86;win-x64;win-arm64</RuntimeIdentifiers> | ||
<AllowUnsafeBlocks>true</AllowUnsafeBlocks> | ||
<Nullable>enable</Nullable> | ||
<DefineConstants Condition="'$(Configuration)' == 'Debug'">$(DefineConstants);TRACE;DEBUG;NETFX_CORE</DefineConstants> | ||
<DefineConstants Condition="'$(Configuration)' != 'Debug'">$(DefineConstants);TRACE;RELEASE;NETFX_CORE</DefineConstants> | ||
<Optimize Condition="'$(Configuration)' != 'Debug'">true</Optimize> | ||
</PropertyGroup> | ||
|
||
</Project> |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are these changes intentional? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The configurations seem to be broken without it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stable, preview, and store configurations were recently removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove them soon