Code Quality: Replace Vanara with CsWin32

[Jack251970]

Removed Vanara.PInvoke.Shell32.CMF & Vanara.PInvokeVanara.PInvoke.RECT import.
Replaced Vanara.PInvoke.Shell32.IApplicationActivationManage with Windows.Win32.UI.Shell.IApplicationActivationManager.
Removed useless Vanara import.

For #15000

[0x5bfa]

This looks great, thank you!

While you're at context menu thing, could you replace these manually defined types with cswin32 too?

Files/src/Files.App/Data/Items/ContextMenu.cs

Lines 6 to 33 in 08ab494

	// Same definition of Vanara.PInvoke.User32.MenuItemType
	public enum MenuItemType : uint
	{
	MFT_STRING = 0,
	MFT_BITMAP = 4,
	MFT_MENUBARBREAK = 32,
	MFT_MENUBREAK = 64,
	MFT_OWNERDRAW = 256,
	MFT_RADIOCHECK = 512,
	MFT_SEPARATOR = 2048,
	MFT_RIGHTORDER = 8192,
	MFT_RIGHTJUSTIFY = 16384
	}
	public enum HBITMAP_HMENU : long
	{
	HBMMENU_CALLBACK = -1,
	HBMMENU_MBAR_CLOSE = 5,
	HBMMENU_MBAR_CLOSE_D = 6,
	HBMMENU_MBAR_MINIMIZE = 3,
	HBMMENU_MBAR_MINIMIZE_D = 7,
	HBMMENU_MBAR_RESTORE = 2,
	HBMMENU_POPUP_CLOSE = 8,
	HBMMENU_POPUP_MAXIMIZE = 10,
	HBMMENU_POPUP_MINIMIZE = 11,
	HBMMENU_POPUP_RESTORE = 9,
	HBMMENU_SYSTEM = 1
	}

[Jack251970]

This looks great, thank you!

While you're at context menu thing, could you replace these manually defined types with cswin32 too?

Files/src/Files.App/Data/Items/ContextMenu.cs

Lines 6 to 33 in 08ab494

	// Same definition of Vanara.PInvoke.User32.MenuItemType
	public enum MenuItemType : uint
	{
	MFT_STRING = 0,
	MFT_BITMAP = 4,
	MFT_MENUBARBREAK = 32,
	MFT_MENUBREAK = 64,
	MFT_OWNERDRAW = 256,
	MFT_RADIOCHECK = 512,
	MFT_SEPARATOR = 2048,
	MFT_RIGHTORDER = 8192,
	MFT_RIGHTJUSTIFY = 16384
	}
	public enum HBITMAP_HMENU : long
	{
	HBMMENU_CALLBACK = -1,
	HBMMENU_MBAR_CLOSE = 5,
	HBMMENU_MBAR_CLOSE_D = 6,
	HBMMENU_MBAR_MINIMIZE = 3,
	HBMMENU_MBAR_MINIMIZE_D = 7,
	HBMMENU_MBAR_RESTORE = 2,
	HBMMENU_POPUP_CLOSE = 8,
	HBMMENU_POPUP_MAXIMIZE = 10,
	HBMMENU_POPUP_MINIMIZE = 11,
	HBMMENU_POPUP_RESTORE = 9,
	HBMMENU_SYSTEM = 1
	}

I will check it later.

[Jack251970]

@0x5bfa As for MFT_SEPARATOR flag, just write MFT_SEPARATOR in NativeMethods.txt cannot help.

As for HBITMAP_HMENU, it is only used for checking in !Enum.IsDefined(typeof(HBITMAP_HMENU), ((IntPtr)menuItemInfo.hbmpItem).ToInt64()).

[0x5bfa]

Add MENU_ITEM_TYPE instead.

As for HBITMAP_HMENU, it is only used for checking in !Enum.IsDefined(typeof(HBITMAP_HMENU), ((IntPtr)menuItemInfo.hbmpItem).ToInt64()).

Maybe we should leave it as is.
Or you could add "HBMMENU_*" and make it work like before.

[Jack251970]

@0x5bfa Have found MENU_ITEM_TYPE and just keep HBITMAP_HMENU.

[0x5bfa]

Thank you so much!

[yaira2]

@Jack251970 thank you!