Feature: View storage information for drives in the Details Pane #16513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
reviewed
Nov 24, 2024
yaira2
reviewed
Nov 24, 2024
src/Files.App/ViewModels/UserControls/Previews/FolderPreviewViewModel.cs
Show resolved
Hide resolved
yaira2
reviewed
Nov 24, 2024
yaira2
reviewed
Nov 24, 2024
yaira2
force-pushed
the
feature_drive_details_preview_pane
branch
from
94b0229
to
d4b1a90
Compare
yaira2
force-pushed
the
feature_drive_details_preview_pane
branch
3 times, most recently
from
a0ced22
to
7a664f8
Compare
0x5bfa
reviewed
Nov 25, 2024
| Margin="12,12,12,24" | ||
| HorizontalAlignment="Center" | ||
| FontFamily="{ThemeResource ContentControlThemeFontFamily}" | ||
| FontSize="14" |
There was a problem hiding this comment.
Can't we use existing styling (StrongBody...) for this? @mdtauk fyi
There was a problem hiding this comment.
BodyStrongTextBlockStyle is SemiBold and not Bold is it fine?
There was a problem hiding this comment.
The concept Martin made looks like using that style.
yaira2
force-pushed
the
feature_drive_details_preview_pane
branch
from
0009131
to
abeab03
Compare
yaira2
changed the title
|
|
yaira2
reviewed
Nov 26, 2024
yaira2
added
ready to merge
|
I've tested the functionality as well. Amazing work @ferrariofilippo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.
Notes
I have NOT tested this feature with
Network Drivessince I have none