Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Update columns in existing tabs after changing the defaults in settings #16512

Merged

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Open some tabs (2 or 3 should be enough), each using Details View
  2. Navigate between folders to build up a back stack
  3. Open Settings/Layout/Details View/Columns
  4. Enable Sync layout ...
  5. Toggle some columns
  6. Check if the layout has been updated in each tab
  7. Navigate back/forward to ensure the new layout is being applied
  8. Repeat 3 -> 6 as many times as you want
  9. Check that the layout is updated even if Sync layout ... is disabled but current tab is using the default layout

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Feature: Refresh Details Layout Columns after changing setting Feature: Update columns in existing tabs after changing the defaults in settings Nov 25, 2024
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 0ee7b9e into files-community:main Nov 26, 2024
6 checks passed
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 26, 2024
@ferrariofilippo ferrariofilippo deleted the feature_refresh_details_layout branch November 26, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Refresh Details Layout Columns after changing setting
4 participants