Fix dependabot not deploying on #main #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bajtos hindsight please |
bajtos
reviewed
Jun 20, 2024
|
Should we deploy this fix to all other GH repos that are automatically deployed to Fly.io from the main branch? I think they are subject to the same problem.
|
|
I think yes, at it's a blind spot and unexpected behavior |
|
@juliangruber I don't remember in which issue we discussed this problem earlier this week. AFAICT, dependabot updates are still not triggering deployment from the 
PR not deployed: #54 |
|
The commit that did not trigger our CI & CD workflow: |
|
Ok trying c6c2022. It was still committing as dependabot[bot] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See dependabot/dependabot-core#3253 (comment)